kevinjqliu commented on PR #3652: URL: https://github.com/apache/iceberg-rust/pull/3652#issuecomment-6868072907
Still reviewing, i want to poke at the api boundary a bit more. Here are a couple of small call outs, neither blocking: 1. [`ArrowReaderBuilder`](https://github.com/apache/iceberg-rust/blob/fa961f5c4e978f93c50b8c117cc32b6228ebf1c8/crates/iceberg/src/arrow/reader/mod.rs#L90) and [`TableScanBuilder`](https://github.com/apache/iceberg-rust/blob/fa961f5c4e978f93c50b8c117cc32b6228ebf1c8/crates/iceberg/src/scan/mod.rs#L179) expose `with_batch_size`, here it's [fixed at 1024](https://github.com/apache/iceberg-rust/blob/fb0629be38dcea5edf8c95863821ff23f61e4496/crates/iceberg/src/arrow/manifest.rs#L53). wdyt about making it configurable? fine to do in a follow up too 2. nit: since these take bytes, maybe mention in the docs that callers need to decrypt first. [`ManifestReader`](https://github.com/apache/iceberg-rust/blob/fa961f5c4e978f93c50b8c117cc32b6228ebf1c8/crates/iceberg/src/spec/manifest/reader.rs#L26) and [`ManifestListReader`](https://github.com/apache/iceberg-rust/blob/fa961f5c4e978f93c50b8c117cc32b6228ebf1c8/crates/iceberg/src/spec/manifest_list/reader.rs#L29) handle that on the io path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
