c-thiel opened a new pull request, #3694: URL: https://github.com/apache/iceberg-rust/pull/3694
## Which issue does this PR close? None yet - do we need one? ## What changes are included in this PR? Every append moved `main` to the new snapshot with an empty retention. This dropped `min-snapshots-to-keep`, `max-snapshot-age-ms` and `max-ref-age-ms` from `main`. A later snapshot expiration (in Java or in this crate) then used the table defaults, and could remove snapshots that the user had asked to keep. `SetSnapshotRef` replaces the whole ref, so the commit now keeps the retention of `main`, as Java's `TableMetadata.Builder.setBranchSnapshot` does. If `main` does not exist yet, the commit creates it without retention, as before. ## Are these changes tested? Yes. `test_commit_keeps_main_branch_retention` in `transaction::snapshot` sets a retention on `main`, appends a snapshot, and checks that the retention is kept. It fails without the fix. The `append_to` test helper now applies the updates the producer returns, so the test checks the real updates. ## AI Disclosure Supported by Claude Code. Reviewed and checked by me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
