jiwen624 commented on code in PR #18941:
URL: https://github.com/apache/iceberg/pull/18941#discussion_r4575671397
##########
api/src/main/java/org/apache/iceberg/transforms/ProjectionUtil.java:
##########
@@ -44,11 +44,17 @@ static <T> UnboundPredicate<T> truncateInteger(
int boundary = pred.literal().value();
switch (pred.op()) {
case LT:
+ if (boundary == Integer.MIN_VALUE) {
+ return null;
Review Comment:
Thanks for the contribution. The repro in #18940 is a real pruning
inefficiency, however its practical impact depends on table size and whether
file statistics eliminate the unnecessary scans. Returning null doesn’t fix it
though: a inclusive projection falls back to `alwaysTrue`, keeping every
partition. For `value > MAX`, this also loses existing pruning of ordinary
partitions such as partition 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]