rdblue commented on a change in pull request #2187:
URL: https://github.com/apache/iceberg/pull/2187#discussion_r568027060
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -78,8 +78,8 @@ case class RewriteMergeInto(spark: SparkSession) extends
Rule[LogicalPlan] with
val joinPlan = Join(source, targetTableScan, LeftAnti, Some(cond),
JoinHint.NONE)
val mergeParams = MergeIntoParams(
- isSourceRowNotPresent = FALSE_LITERAL,
Review comment:
I agree with using positive flags instead of negative ones. Negatives
are harder to reason about when using them because you may need to negate
again: `!noMatchInSource` is harder than `isPresentInSource`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
