adiranjan25 commented on issue #18943: URL: https://github.com/apache/iceberg/issues/18943#issuecomment-6888592997
Hi @wombatu-kun and Iceberg maintainers, Following up on my earlier comment, I've reproduced the reported regression against the current `origin/main` (`234d55774`). I added two focused regression tests using a counting `S3FileIOAwsClientFactory` and mocked S3 clients, without requiring AWS credentials. **Results:** - `testPreloadCreatesClientDuringInitialize()` — FAILS: expected one S3 client to be created during `initialize()`, but observed zero. - `testDefaultInitializationRemainsLazy()` — PASSES, confirming that default lazy initialization remains unchanged. The tests compile and run successfully, with the first failing specifically on the expected assertion. I'm ready to implement the fix and add regression coverage. Before proceeding, could you confirm whether the preferred approach is to restore eager initialization or deprecate `s3.preload-client-enabled`, considering the previous Lake Formation table-creation issues? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
