JeonDaehong commented on code in PR #18622:
URL: https://github.com/apache/iceberg/pull/18622#discussion_r4577046204
##########
api/src/main/java/org/apache/iceberg/types/Comparators.java:
##########
@@ -46,7 +47,7 @@ private Comparators() {}
.put(Types.TimestampNanoType.withZone(), Comparator.naturalOrder())
.put(Types.TimestampNanoType.withoutZone(),
Comparator.naturalOrder())
.put(Types.StringType.get(), Comparators.charSequences())
- .put(Types.UUIDType.get(), Comparator.naturalOrder())
+ .put(Types.UUIDType.get(), Comparators.uuids())
Review Comment:
Agreed, the two paths need the same order before this can go in. I couldn't
find a dev@ thread on UUID ordering yet. If it helps, I can start one with the
cases from this PR: the manifest-list bounds and the metrics evaluators
disagreeing on UUIDs whose high bit differs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]