huaxingao commented on code in PR #18851:
URL: https://github.com/apache/iceberg/pull/18851#discussion_r4577142606


##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedReaderBuilder.java:
##########
@@ -163,14 +170,41 @@ public ParquetVariantVisitor<VectorizedReader<?>> 
variantVisitor() {
       return null;
     }
 
+    if (isShredded(variant.asGroupType())) {

Review Comment:
   Since shredded variants now return here, VectorizedVariantVisitor never sees 
typed_value, so the "Unsupported variant: shredded typed_value ..." throws in 
primitive()/value()/object()/array() are unreachable. Fine to keep them if the 
vectorized reconstruction PRs in #18669 will replace them, but maybe a short 
comment there so readers don't think this case still fails?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to