badalprasadsingh commented on code in PR #2592:
URL: https://github.com/apache/iceberg-go/pull/2592#discussion_r4577248339


##########
schema_identifier_fields_validation_test.go:
##########
@@ -49,6 +49,12 @@ func TestValidateIdentifierFields(t *testing.T) {
                {"double", []int{1}, []NestedField{{
                        ID: 1, Name: "id", Type: PrimitiveTypes.Float64, 
Required: true,
                }}, "float or double"},
+               {"float pointer", []int{1}, []NestedField{{
+                       ID: 1, Name: "id", Type: &Float32Type{}, Required: true,
+               }}, "float or double"},
+               {"double pointer", []int{1}, []NestedField{{
+                       ID: 1, Name: "id", Type: &Float64Type{}, Required: true,
+               }}, "float or double"},

Review Comment:
   can you add a pointer case that must still pass? no test checks that other 
pointer types, like "&Int64Type{}", stay valid identifiers, so a check that 
rejects every pointer type would go unnoticed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to