c-thiel commented on PR #3693:
URL: https://github.com/apache/iceberg-rust/pull/3693#issuecomment-6894261397

   @laskoviymishka Thanks for the review. I added both tests and a changelog 
line:
   
   - `test_table_metadata_v1_invalid_refs_fail_to_load` edits the fixture for 
the three `validate_refs` errors (a dangling ref, `main` not matching 
`current-snapshot-id`, and `current-snapshot-id: -1` with `main`) and checks 
the exact messages.
   - `test_v1_refs_protect_their_snapshots` loads the fixture and runs expire 
with the table defaults. `b1` keeps the snapshot it shares with `t1`, so only 
the middle snapshot on `main` expires. `t1` itself is removed, because it is 
older than its `max-ref-age-ms` of 7 days, as in Java. Without this PR, the 
same run also expires the snapshot of `t1` and `b1`.
   - `CHANGELOG.md` has a line under Breaking Changes: v1 metadata keeps its 
refs, and v1 metadata with invalid refs now fails to load.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to