ump45nose commented on PR #3522: URL: https://github.com/apache/iceberg-rust/pull/3522#issuecomment-6894825048
Rebased onto current main (`6612395`, which includes #3483 and #3424) and pushed 4adddcc on top. - **Compile break:** the column-stats path added in #3424 (`bound_as_column_type` in `scan/task.rs`) called `Datum::promote_to` as an `Option`. It now matches `Ok(Some(_))`, so a date bound that overflows the promoted timestamp type is dropped there and only that column loses pruning. - **Review nits:** conversion moved to `temporal.rs`, and `PrimitiveLiteral::promote_to` is documented against `Datum::promote_to` (replies inline). Local on this head: `cargo test -p iceberg --lib` 2204 passed, 0 failed (1 ignored); `cargo clippy -p iceberg --all-targets -- -D warnings` clean; `cargo fmt --all` clean. (AI-assisted change and comment.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
