nssalian opened a new pull request, #24: URL: https://github.com/apache/iceberg-verification/pull/24
Closes https://github.com/apache/iceberg-verification/issues/18 The reference-tables have no table with a delete file, so nothing currently checks that a reader applies a v3 deletion vector. This adds `v3/deletion-vector-parquet-data`. Snapshot 1 appends `a.parquet` (ids 1 to 5) and `b.parquet` (ids 6 and 7). Snapshot 2 adds one deletion vector that deletes positions 0 and 3 of `a.parquet`, so a scan returns ids 2, 3, 5, 6 and 7. `b.parquet` has no deletion vector, so a reader that applies it to every data file fails. The spec applies a deletion vector only when "The data file's `file_path` is equal to the deletion vector's `referenced_data_file`". The table is generated by `GenerateTables.java` from the Input block in its README. Two optional commit keys make that possible: `data-files` (several data files in one append) and `deletion-vector` (positions of a named data file). The existing tables generate unchanged. Checked at both snapshots with a raw fastavro/pyarrow reader, PyIceberg 0.12.0, Iceberg Java 1.12.0, iceberg-go (d66ab48) and iceberg-rust 0.11.0. All match `expected/scan.json`. iceberg-rust 0.10.1 fails the second snapshot because it has no Puffin deletion vector loader. This is an addition, not a correction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
