rdblue commented on a change in pull request #2189:
URL: https://github.com/apache/iceberg/pull/2189#discussion_r568175418
##########
File path:
spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java
##########
@@ -48,6 +48,55 @@ public void removeTables() {
sql("DROP TABLE IF EXISTS source");
}
+ // TODO: add tests for multiple NOT MATCHED clauses when we move to Spark 3.1
+
+ @Test
+ public void testMergeInsertOnly() {
+ createAndInitTable("id STRING, v STRING",
+ "{ \"id\": \"a\", \"v\": \"v1\" }\n" +
+ "{ \"id\": \"b\", \"v\": \"v2\" }");
+ createOrReplaceView("source",
+ "{ \"id\": \"a\", \"v\": \"v1_1\" }\n" +
+ "{ \"id\": \"a\", \"v\": \"v1_2\" }\n" +
+ "{ \"id\": \"c\", \"v\": \"v3\" }\n" +
+ "{ \"id\": \"d\", \"v\": \"v4_1\" }\n" +
+ "{ \"id\": \"d\", \"v\": \"v4_2\" }");
Review comment:
Not a blocker for this test, but I think embedded JSON is hard to read.
I'm wondering if we should have a test helper class that has static methods
to build these JSON structures:
```java
createOrReplaceView("source",
map("id", "a", "v", "v1_1"),
...);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
