Revanth14 commented on PR #2614: URL: https://github.com/apache/iceberg-go/pull/2614#issuecomment-6907215685
@zeroshade @laskoviymishka for PR 3. After this PR, inspect still needs `ManifestProvider.uniqueManifests`, which walks the provider's private manifest cache with bounded prefetch, so it can't move to `table/internal`. Should I export it as `ManifestProvider.UniqueManifests` next to `Manifests` and `FS`, or have inspect dedupe over `Manifests()` and give up the prefetch for the `all_*` tables? I'd lean towards exporting the one method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
