stevenzwu commented on pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#issuecomment-771215176


   @openinx I enabled `TestFlinkCatalogTable#testCreateTableIfNotExists()` 
test. I have to make two adjustments. In particular, I have to remove `WITH 
('location'='/tmp/location')"` from the SQL in 2nd create. Otherwise, 
HadoopCatalog fails the validation. Also, for this test purpose, it is probably 
not important for the 2nd create to set a new location.
   
   ```
   Test testCreateTableIfNotExists[catalogName = testhadoop baseNamespace = 
](org.apache.iceberg.flink.TestFlinkCatalogTable) failed with:
   org.apache.flink.table.api.TableException: Could not execute CreateTable in 
path `testhadoop`.`db`.`tl`
     at 
org.apache.flink.table.catalog.CatalogManager.execute(CatalogManager.java:796)
     at 
org.apache.flink.table.catalog.CatalogManager.createTable(CatalogManager.java:632)
     at 
org.apache.flink.table.api.internal.TableEnvironmentImpl.executeOperation(TableEnvironmentImpl.java:776)
     at 
org.apache.flink.table.api.internal.TableEnvironmentImpl.executeSql(TableEnvironmentImpl.java:666)
     at org.apache.iceberg.flink.FlinkTestBase.exec(FlinkTestBase.java:103)
     at org.apache.iceberg.flink.FlinkTestBase.exec(FlinkTestBase.java:107)
     at org.apache.iceberg.flink.FlinkTestBase.sql(FlinkTestBase.java:111)
     at 
org.apache.iceberg.flink.TestFlinkCatalogTable.testCreateTableIfNotExists(TestFlinkCatalogTable.java:139)
     ...
    Caused by: java.lang.IllegalArgumentException: Cannot set a custom location 
for a path-based table. Expected 
file:///var/folders/4d/3shff9g95pz81jmgrcn74zl00000gn/T/junit5877951167101792089/db/tl
 but got /tmp/location
     at 
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
     at 
org.apache.iceberg.hadoop.HadoopCatalog$HadoopCatalogTableBuilder.withLocation(HadoopCatalog.java:441)
     at 
org.apache.iceberg.CachingCatalog$CachingTableBuilder.withLocation(CachingCatalog.java:191)
     at org.apache.iceberg.CachingCatalog.createTable(CachingCatalog.java:104)
     at org.apache.iceberg.flink.FlinkCatalog.createTable(FlinkCatalog.java:377)
     at 
org.apache.flink.table.catalog.CatalogManager.lambda$createTable$10(CatalogManager.java:633)
     at 
org.apache.flink.table.catalog.CatalogManager.execute(CatalogManager.java:790)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to