fmorillo7694 opened a new pull request, #18994: URL: https://github.com/apache/iceberg/pull/18994
The v4 spec forbids adding new equality delete files (#17783, [vote](https://lists.apache.org/thread/5x8ovvz3ppf4krqs543sqjcy3dqdhthm)), but in UPSERT mode the Flink sinks write an equality delete for every row. `IcebergSink`, `FlinkSink` and `DynamicIcebergSink` now reject UPSERT on a table whose format version forbids equality deletes, naming the table and version in the error. The builder sinks check when the job is built, and the dynamic sink checks when it loads each table. v1 to v3 are unchanged. Core-side enforcement, which also covers non-UPSERT changelog writes, is in #18993. Test plan: `TestUpsertFormatVersion` covers both builder sinks on v4 and v3, and a new `TestDynamicWriter` case covers the dynamic sink on v4. With the check disabled, all three v4 cases fail. `TestIcebergSinkV2` and `TestFlinkIcebergSinkV2` still pass. --- **AI Disclosure** - Model: Claude (Anthropic) - Platform/Tool: Kiro (Kiro Crew) - Human Oversight: partially reviewed - Prompt Summary: Make the Flink 2.3 sinks fail early when UPSERT targets a v4 table, since v4 forbids new equality deletes. The guard and its tests are generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
