Rahul-cs50 commented on PR #4219: URL: https://github.com/apache/iceberg-python/pull/4219#issuecomment-6915035417
Thanks for the careful review! Good catch on the NaN branch. I'd like to keep this PR to nulls and handle NaN in a follow-up, with a NaN float column added to that test. Here I'll drop the unused null half of the collector and switch the repr check to a behaviour assertion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
