gaborkaszab commented on code in PR #18924:
URL: https://github.com/apache/iceberg/pull/18924#discussion_r4585904528
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -180,6 +180,15 @@ default String rootManifestLocation() {
return null;
}
+ /**
+ * Return the size in bytes of this snapshot's root manifest, or null if it
has no root manifest.
+ *
+ * @return the size in bytes of the root manifest for this snapshot
+ */
+ default Long rootSizeInBytes() {
Review Comment:
The name of the physical field originally was `root-manifest-size-in-bytes`
but that was too long and after @rdblue 's suggestion I renamed it to
`root-size-in-bytes`.
I think it a good idea to keep the member's name in the implementation
consistent with the name of the physical field, so I'm hesitant calling this
`rootManifestSizeInBytes()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]