dramaticlly commented on PR #18631:
URL: https://github.com/apache/iceberg/pull/18631#issuecomment-6923564565

   > > I think suggestion might be malformed and 
[eeeafc5](https://github.com/apache/iceberg/commit/eeeafc55d59c6d5d536a6779974b4856ae6543e4)
 ends up drop the javadoc instead
   > 
   > I suggested to drop Javadoc because it's rather misleading to say `Copies 
all fields from an existing delete file, including its content type and 
equality field ID`. It's probably better to omit it in this case
   
   Thanks for the context. Spot checking a few other public copy method in 
implementation class, common to omit and I think no java doc is ok to accept in 
this case. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to