iceberg-kitten opened a new pull request, #2624:
URL: https://github.com/apache/iceberg-go/pull/2624

   ## What
   
   Include existing position deletes in the new DV for the same data file.
   
   ## Why
   
   The Iceberg spec requires existing v2 position deletes to be written into a 
DV when position deletes for a data file are updated. Readers may skip matching 
position-delete files once a DV exists. If the old deletes are not carried 
forward, deleted rows can appear again.
   
   - Spec: [Position Delete 
Files](https://iceberg.apache.org/spec/#position-delete-files) and [Deletion 
Vectors](https://iceberg.apache.org/spec/#deletion-vectors)
   - Java: Spark selects existing deletes for rewrite when DVs are used and 
loads their positions before writing: [selects 
files](https://github.com/apache/iceberg/blob/main/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java#L212-L224),
 [loads 
positions](https://github.com/apache/iceberg/blob/main/spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java#L528-L587)
   
   ## Implementation
   
   Reuse delete entries from scan planning and merge positions per data file. 
Cover a single data file and a position-delete file shared by two data files.
   
   Fixes #2604.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to