rdblue opened a new pull request, #19007:
URL: https://github.com/apache/iceberg/pull/19007

   This adds tests for writing leaf manifest files to `TestV4ManifestWriter`.
   
   Changes to the writer:
   - `assignedRowIds()` is `@VisibleForTesting` and used to validate the total 
assignment in the root writer and in tests
   - Updated manifest row ID assignment to include 
`manifestInfo.modifiedRowsCount()`, which used to be part of existing
   - Updated writer methods to check file content
       - Data files are allowed in all methods
       - Data manifests are allowed in all methods except for `appendAtSeq`
       - Delete manifests may be `existing` or `deleted` but cannot be 
appended, modified, or replaced
       - Delete files are not allowed
   - Moved stats updates after `prepare` in `write`
   
   The test plan is similar to #18984:
   - Validate metadata fields valid for manifests
       - Manifest DV is tested but cannot be added
       - Column files are tested but cannot be added
   - Test each status: append, existing, deleted, replaced (not modify)
       - Modify manifest DV is not implemented
       - Append manifest at a data sequence number is not allowed
       - Do not test that delete files or delete manifests are rejected by 
preconditions
   - Test mixed manifest and data file writes
   - Row ID assignment
       - All tests now validate `assignedRowIds()` as @amogh-jahagirdar 
suggested
       - Mixed data file and data manifests
   
   This also updates `ManifestInfoStruct` to accept a `MutableBitmap` instead 
of `byte[]`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to