badalprasadsingh commented on code in PR #2601: URL: https://github.com/apache/iceberg-go/pull/2601#discussion_r4597925222
########## website/src/cli.md: ########## @@ -217,6 +217,8 @@ iceberg expire-snapshots --older-than 7d --dry-run my_db.events iceberg expire-snapshots --older-than 7d --retain-last 5 my_db.events ``` +For REST catalogs, the `iceberg expire-snapshots` command requires complete snapshot history. Configure `snapshot-loading-mode=all` before running it; `snapshot-loading-mode=refs` omits history needed to enforce retention and causes expiration to fail. Review Comment: make it: ```md iceberg expire-snapshots fails when the REST server sets snapshot-loading-mode=refs; the CLI cannot override it. ``` cli can't set snapshot-loading-mode: there is no flag, and `.iceberg-go.yaml` silently ignores the key, so refs mode only comes from the server's config. the branch note at lin314 has the same gap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
