Anurag-S1ngh opened a new pull request, #4405: URL: https://github.com/apache/iceberg-python/pull/4405
## Summary `_s3` registered the remote signer on the botocore client, which s3fs caches and every thread shares. Unregistering the signer before registering it again left a window in which a request went out without an `Authorization` header, and the store answered 403 against a remote-signing catalog. ## Changes - Create an `AioSession` per filesystem, register the signer on its event emitter, and pass it to `S3FileSystem`. - Forward the `profile` property to the session, since s3fs no longer creates the session. - Leave the path without a signer unchanged. This is the approach of #3783, which was closed for inactivity, with regression tests for the signer itself. ## Testing - Added a test that the session handed to `S3FileSystem` signs a `before-sign.s3` request, and one that two configurations get independent sessions and signers. - `make test` passes (4694 passed, 5 skipped). Note: #4270 also mentions this issue, but it fixes the duplicate header defect from #2422 and does not change the signer registration. Closes #3896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
