Fokko commented on code in PR #4398:
URL: https://github.com/apache/iceberg-python/pull/4398#discussion_r4600051881


##########
mkdocs/docs/configuration.md:
##########
@@ -93,6 +93,7 @@ Iceberg tables support table properties to configure table 
behavior.
 | `write.summary.partition-limit`          | Integer                           
 | 0                          | Maximum number of changed partitions for which 
per-partition summaries are included in the snapshot summary. The default of 0 
disables them          |
 | `write.metadata.previous-versions-max`   | Integer                           
 | 100                        | The max number of previous version metadata 
files to keep before deleting after commit.                                     
                         |
 | `write.metadata.delete-after-commit.enabled` | Boolean                       
 | False                      | Whether to automatically delete old *tracked* 
metadata files after each table commit. It will retain a number of the most 
recent metadata files, which can be set using property 
`write.metadata.previous-versions-max`. |
+| `write.metadata.compression-codec`       | `{none,gzip}`                     
 | none                       | Compression for the table metadata files that 
PyIceberg writes. `gzip` names new metadata files `*.gz.metadata.json` and 
gzips them. REST catalogs are unaffected, since the server chooses the metadata 
file location. |

Review Comment:
   If the property lives on the table, it could affect REST
   ```suggestion
   | `write.metadata.compression-codec`       | `{none,gzip}`                   
   | none                       | Compression for the table metadata files that 
PyIceberg writes. `gzip` names new metadata files `*.gz.metadata.json` and 
gzips them. |
   ```



##########
mkdocs/docs/configuration.md:
##########
@@ -93,6 +93,7 @@ Iceberg tables support table properties to configure table 
behavior.
 | `write.summary.partition-limit`          | Integer                           
 | 0                          | Maximum number of changed partitions for which 
per-partition summaries are included in the snapshot summary. The default of 0 
disables them          |
 | `write.metadata.previous-versions-max`   | Integer                           
 | 100                        | The max number of previous version metadata 
files to keep before deleting after commit.                                     
                         |
 | `write.metadata.delete-after-commit.enabled` | Boolean                       
 | False                      | Whether to automatically delete old *tracked* 
metadata files after each table commit. It will retain a number of the most 
recent metadata files, which can be set using property 
`write.metadata.previous-versions-max`. |
+| `write.metadata.compression-codec`       | `{none,gzip}`                     
 | none                       | Compression for the table metadata files that 
PyIceberg writes. `gzip` names new metadata files `*.gz.metadata.json` and 
gzips them. REST catalogs are unaffected, since the server chooses the metadata 
file location. |

Review Comment:
   If the property lives on the table, it could affect REST
   ```suggestion
   | `write.metadata.compression-codec`       | `{none,gzip}`                   
   | none                       | Compression for the table metadata files that 
PyIceberg writes. `gzip` names new metadata files `*.gz.metadata.json` and 
gzips them. |
   ```
   
   Maybe just leave it out?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to