manuzhang opened a new pull request, #1139: URL: https://github.com/apache/iceberg-cpp/pull/1139
`SnapshotsScan`, `HistoryScan`, and `RefsScan` are only needed by their respective metadata table implementations, but their definitions and direct `Make()` factories are exported in installed headers. Move the concrete classes and their method definitions into anonymous namespaces in the corresponding `.cc` files. Callers create scans through `MetadataTable::NewScan()` and `MetadataScanBuilder::Build()`, then use the `MetadataScan` interface. This removes the three concrete types and their direct factories from the public API/ABI. The table APIs and scan behavior are preserved. This PR is based directly on main and is independent of #1120. Validation: rebuilt the metadata scan implementations and tests against the main-based source tree, reusing cached unchanged static dependencies; all 55 metadata tests and C++20 compatibility passed. Compiler probes confirm all three concrete names are unavailable through public headers, and symbol inspection confirms the implementation objects export none of those classes. Required pre-commit and changed-file clang-tidy passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
