ialarmedalien commented on code in PR #4408:
URL: https://github.com/apache/iceberg-python/pull/4408#discussion_r4601822369


##########
pyiceberg/catalog/sql.py:
##########
@@ -617,20 +617,24 @@ def create_namespace(self, namespace: str | Identifier, 
properties: Properties =
         if self.namespace_exists(namespace):
             raise NamespaceAlreadyExistsError(f"Namespace {namespace} already 
exists")
 
-        if not properties:
-            properties = 
IcebergNamespaceProperties.NAMESPACE_MINIMAL_PROPERTIES

Review Comment:
   redundant with the next line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to