sungwy opened a new pull request, #19013:
URL: https://github.com/apache/iceberg/pull/19013

   `RESTSessionCatalog` serves many engine sessions, but a table FileIO cannot 
authenticate its catalog requests, such as credential refresh and remote 
signing, as the session that loaded the table. With 
`rest.auth.file-io-session.enabled`, the catalog attaches a 
`KeyedTokenAuthSession` to each table FileIO whose session differs from the 
catalog session. Only the key is serialized. On the loading node the session 
reads the current token from the `AuthManager` through `TokenSource`. On 
workers it resolves the key through a `TokenResolver` that the engine installs, 
and never acquires a token. Legacy `OAuth2Manager` sessions implement 
`TokenSource`. The catalog marks the FileIO properties so that `AuthManagers` 
refuses to build a manager from them. No FileIO consumes the session yet; 
`S3FileIO`, `GCSFileIO` and `ADLSFileIO` follow separately.
   
   Design: 
https://docs.google.com/document/d/1zr67n8ZGHKz29PNYauq_DIv_tb0ElrvY1gasKnGLsXI/edit
   
   Issue: [unknown - human to fill in]
   
   Test plan:
   - Keys are shared within a session and distinct across sessions, catalog 
instances and server-issued table tokens, so one user's FileIO never presents 
another user's token.
   - Server config can neither enable the feature nor clear the marker, because 
only client properties may opt in.
   - Java, Kryo and `FileIOParser` serialization carry only the key, and 
`ResolvingFileIO` forwards the session to its delegates.
   - Scheduled renewal keeps each user's token for that user, and a rejected 
renewal fails only that user.
   - Every gap fails closed: no resolver, an unknown or expired key, a closed 
catalog, a non-bearer session, a FileIO without the mixin, a shared FileIO 
taking a second session, and an `AuthManager` loaded from marked properties.
   
   ---
   **AI Disclosure**
   - Model: Claude Opus 5.5
   - Platform/Tool: Claude Code
   - Human Design and Oversight: Sung Yun
   - Prompt Summary: Implement the author's design for propagating user auth 
sessions to table FileIOs. The code and tests are generated; the design, API 
choices and scope are the author's.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to