zeroshade commented on code in PR #2590:
URL: https://github.com/apache/iceberg-go/pull/2590#discussion_r4603737374
##########
table/update_schema.go:
##########
@@ -1101,7 +1101,9 @@ func (u *UpdateSchema) BuildUpdates() ([]Update,
[]Requirement, error) {
updates = append(
updates,
NewAddSchemaUpdate(newSchema),
- NewSetCurrentSchemaUpdate(newSchema.ID),
+ // -1 selects the last added schema; the
catalog may assign newSchema a different ID.
+ // Matches Java. Java catalogs reject it if a
concurrent writer added an equivalent schema.
Review Comment:
nit: could this be one sentence? e.g.
```suggestion
// Java's SchemaUpdate sends the same pair;
Java catalogs reject -1 when a concurrent writer already added an equivalent
schema.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]