anoopj commented on code in PR #19006:
URL: https://github.com/apache/iceberg/pull/19006#discussion_r4607469624
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -195,6 +195,11 @@ public List<Snapshot> apply() {
private TableMetadata internalApply() {
this.base = ops.refresh();
+ ValidationException.check(
+ CleanupLevel.NONE == cleanupLevel || !hasRootManifestSnapshot(base),
Review Comment:
Thanks for flagging this. With `CleanupLevel.NONE` +
`cleanExpiredMetadata(true)`, I think it should still run into the check you
mentioned, so i think we are OK because it should fail before commiting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]