stevenzwu commented on code in PR #19021:
URL: https://github.com/apache/iceberg/pull/19021#discussion_r4609105730


##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -359,7 +359,7 @@ public LocationProvider locationProvider() {
 
     @Override
     public String metadataFileLocation(String fileName) {
-      return new File(metadata, fileName).getAbsolutePath();
+      return new File(metadata, fileName).toURI().toString();

Review Comment:
   is this changed intended?



##########
core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java:
##########
@@ -169,7 +169,7 @@ public void testV2WriteWithInheritance() throws IOException 
{
   }
 
   @ParameterizedTest
-  @FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS")
+  @FieldSource("org.apache.iceberg.TestHelpers#V3_AND_BELOW")

Review Comment:
   `TestBase.formatVersions()` does not apply here — JUnit uses this 
`@FieldSource`. You already switched it to `V3_AND_BELOW`.
   
   Still needed on other write-path tests that keep `ALL_VERSIONS` / 
`V2_AND_ABOVE` (or hardcode 4): `TestManifestFileUtil`, 
`TestTaskEqualityDeltaWriter`, `TestDVWriters`, Spark 
`TestDeleteReachableFilesAction` / `TestRemoveOrphanFilesAction` / 
`TestRewriteDataFilesAction` / `TestSparkReaderDeletes` / 
`TestPositionDeletesReader` / `TestSparkMetadataColumns` / `TestDeleteFrom` / 
`TestExpireSnapshotsActionV4`, Flink `TestDeltaTaskWriter` / `TestFlinkUpsert` 
/ `TestIcebergCommitter` / `TestRewriteDataFilesAction`. Leave `ALL_VERSIONS` 
on metadata-only tests.
   
   ---
   <sub>🤖 Posted by an AI agent  on behalf of @stevenzwu.</sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to