linzch3 opened a new pull request, #4416:
URL: https://github.com/apache/iceberg-python/pull/4416

   # Rationale for this change
   
   An incomplete row filter such as `id =` or `id IN ()` currently reports a 
long list of parser alternatives. Name the two literal expressions so those 
inputs report `Expected a literal value` and `Expected a non-empty list of 
literals`, respectively.
   
   This addresses the parser error-message portion of #2860.
   
   ## Are these changes tested?
   
   Both new regression cases fail on the base commit and pass with this change. 
All 46 parser tests pass. `make test` passed with 4,752 tests passing and 5 
skipped, and `make lint` passed.
   
   ## Are there any user-facing changes?
   
   Error messages for missing scalar literals and empty literal lists are 
clearer. Valid filters parse as before.
   
   ## AI assistance
   
   An AI assistant helped reproduce the parser errors, identify where to name 
the literal expressions, and write and run the regression tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to