JosephLenton commented on code in PR #2916:
URL: https://github.com/apache/iceberg-rust/pull/2916#discussion_r4612426859


##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -106,6 +109,12 @@ pub(crate) mod _serde {
         Double(f64),
         String(String),
         Bytes(ByteBuf),
+        // Note with the use of `serialize_with` here:
+        //  - it is to ensure we get an Avro Value::Fixed, and not 
Value::Bytes.
+        //    This is for UUID support. The spec requires that UUIDs _must_ 
use `Value::Fixed`.
+        //  - `apache_avro::serde::fixed::serialize` only affects the 
behaviour of
+        //    `apache_avro::serde::to_value`. Internally it sets a thread 
local flag for Avro.

Review Comment:
   I've updated to your comment 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to