laskoviymishka opened a new pull request, #2637:
URL: https://github.com/apache/iceberg-go/pull/2637

   Follow-up to #2605, found by @nssalian in review of #2620. Promote an 
identity `int` partition source to `long`, append `p=5` before and after, and 
`tbl.Inspect().Partitions()` returns two rows for `p=5`. Old manifests decode 
the value as int32 and new ones as int64, and the partition aggregate tree keys 
them apart. `CoercePartition` and `LookupPartition` now widen int32 to int64 
for long fields and float32 to float64 for double fields, so the partitions 
table and partition statistics agree without changes of their own. Both 
widenings are exact, so nothing that differed before now matches.
   
   Added unit cases in `table/internal` for int to long, float to double 
(including NaN), a float32 value that still differs from the float64 literal 
after widening, and an int field that does not widen. A partition statistics 
test reads one manifest with `p=int32(5)` and one with `p=int64(5)` against a 
long partition type and expects a single row; it returns two rows on main. The 
inspect path goes through the same two helpers and is covered by the 
`table/internal` cases; an end-to-end `Inspect().Partitions()` test fits better 
with #2631, which moves the inspect code and tests.
   
   `ComputePartitionStatistics` still rejects tables whose identity source type 
changed. Lifting that is left for a separate change.
   
   AI-assisted, reviewed by a human.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to