DerGut commented on code in PR #3667:
URL: https://github.com/apache/iceberg-rust/pull/3667#discussion_r4614397494


##########
crates/iceberg/src/scan/context.rs:
##########
@@ -354,21 +395,29 @@ impl PlanContext {
                     )
                     .eval(manifest_file)?
                 {
-                    continue;
+                    skipped = true;
                 }
 
                 Some(partition_bound_predicate)
             } else {
                 None
             };
 
+            if skipped {

Review Comment:
   Thanks for the review Alex! I realized that this PR's diff size was probably 
too large and started to split out some work.
   The issue you found here is now fixed separately in 
https://github.com/apache/iceberg-rust/pull/3708 but I didn't update the 
harness yet accordingly, sorry about that! 🙏 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to