JeonDaehong commented on code in PR #3590:
URL: https://github.com/apache/iceberg-rust/pull/3590#discussion_r4615376039


##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -170,8 +171,21 @@ impl FileWriterBuilder for ParquetWriterBuilder {
             .encryption_manager
             .as_ref()
             .map(|em| em.generate_key_metadata());
-        let writer_properties =
-            resolve_writer_properties(self.props.clone(), 
key_metadata.as_ref())?;
+        let mut props = self.props.clone();
+        // Like Java's `MetricsConfig.forPositionDelete`, keep full statistics 
for a position
+        // delete file. A truncated `file_path` gives unequal bounds, so the 
file can no
+        // longer be matched to the one data file it references.

Review Comment:
   Thanks @mbutrovich, both are in 4c794911: the comment now uses your wording, 
and the `ParquetWriterBuilder` docs say truncation is turned off for the 
position delete schema regardless of `WriterProperties`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to