laskoviymishka commented on code in PR #2631:
URL: https://github.com/apache/iceberg-go/pull/2631#discussion_r4618027155
##########
table/inspect/inspect.go:
##########
@@ -223,7 +237,7 @@ func (i InspectTable) Snapshots(ctx context.Context)
(array.RecordReader, error)
// Summary.MarshalJSON). Emit it alongside the extra
properties so
// the table faithfully reflects the on-disk summary.
if snap.Summary.Operation != "" {
- summaryKeys.Append(operationKey)
+ summaryKeys.Append("operation")
Review Comment:
Could this keep one source for the key? `main` used `operationKey` here, and
it's still unexported in
[table/snapshots.go](https://github.com/apache/iceberg-go/blob/c5da81976afc0326ba71d1bfc0a19a7addb04a88/table/snapshots.go#L63),
so nothing ties this literal to `Summary.MarshalJSON` anymore. Exporting the
constant would fix that, at the cost of one more public name before v1.
##########
table/snapshot_manifest_cache.go:
##########
@@ -361,12 +361,12 @@ func (p ManifestProvider) Manifests(ctx context.Context,
snapshot Snapshot) (ite
return slices.Values(set.borrowAllManifests()), nil
}
-// uniqueManifests yields the distinct manifest descriptors referenced by the
+// UniqueManifests yields the distinct manifest descriptors referenced by the
// given snapshots, in first-seen order. It reads manifest lists but not the
// manifest Avro files themselves. The caller must not modify snapshots during
// iteration. It shares this provider's bounded cache and FileIO, with bounded
// concurrent prefetch of historical lists. An error ends the sequence.
Review Comment:
Now that this is exported, could the godoc say what "distinct" means? Dedup
is keyed on `manifest.FilePath()`
([snapshot_manifest_stream.go](https://github.com/apache/iceberg-go/blob/c5da81976afc0326ba71d1bfc0a19a7addb04a88/table/snapshot_manifest_stream.go#L73-L77)),
which callers outside `table` can't see.
```suggestion
// concurrent prefetch of historical lists. An error ends the sequence.
// Manifests are deduplicated by manifest file path.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]