danielcweeks commented on code in PR #16972: URL: https://github.com/apache/iceberg/pull/16972#discussion_r4618091651
########## format/expressions-spec.md: ########## @@ -228,6 +228,68 @@ Note that `year`, `month`, and `hour` transforms produce ordinal values and not [bucket-ref]: spec.md#bucket-transform-details [truncate-ref]: spec.md#truncate-transform-details +### Collation functions Review Comment: I'm not convinced this belongs in the expressions spec. This spec is purely to define the representation of expressions. I feel like this info is better defined somewhere else (maybe the table spec?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
