AP24110011695 commented on PR #4412: URL: https://github.com/apache/iceberg-python/pull/4412#issuecomment-6988968280
Good question, and the answer is no — #4401 covers everything this PR did and a bit more. Same writer scope (top-level float/double, counts from the data before writing, accumulated across repeated `write()` calls), plus the none-metrics-mode handling I had missed entirely. For the record, #4396 was opened on Nov 16 (the NaN counts were never accumulated by the writer — the metrics evaluator's nan-based pruning was silently dead for pyiceberg-written files), and #4401 picking it up the next morning and merging is exactly how that should have played out. My branch raced it and lost, and it now conflicts with main as you noted. Closing this one — thanks for checking rather than letting a conflicting duplicate sit. The open thread on #4396 is the `add_files` path, which #4401 explicitly left for a separate change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
