paleolimbot opened a new pull request, #4422:
URL: https://github.com/apache/iceberg-python/pull/4422

   # Rationale for this change
   
   Support for geometry and geography is roughed in, but as noted in 
https://github.com/apache/iceberg-python/issues/4079 , not all of the edge 
algorithms are mapped and there is at least one correctness issue in the 
conversion from Iceberg -> GeoArrow. Also, the mechanism by which the types are 
parsed fails because the CRS is not quoted.
   
   This PR adds one end-to-end read test (Spark writes, PyIceberg reads), and 
adds the transformation in the other direction (GeoArrow -> PyIceberg) that 
matches the conversion that pyarrow will do when it writes the Parquet files.
   
   While I was here I simplified the dependency from geoarrow-python to 
geaorrow-types. I maintain both, and geoarrow-types is pure Python and a better 
fit for what you're trying to do here.
   
   I can remove any of this...I was just reviewing this in iceberg-rust and 
thought I'd poke thie along and these all seemed like easy/testable next steps.
   
   ## Are these changes tested?
   
   Yes
   
   ## Are there any user-facing changes?
   
   Yes, after this PR GEOMETRY/GEOGRAPHY tables written by Spark (and possibly 
others) can now be read.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to