zeroshade commented on code in PR #167:
URL:
https://github.com/apache/terraform-provider-iceberg/pull/167#discussion_r4620407848
##########
internal/provider/resource_table.go:
##########
@@ -114,6 +117,12 @@ func (r *icebergTableResource) Schema(_ context.Context, _
resource.SchemaReques
Computed: true,
ElementType: types.StringType,
},
+ "purge_on_destroy": rscschema.BoolAttribute{
Review Comment:
Optional doc addition: like `force_destroy` on `aws_s3_bucket`,
`purge_on_destroy = true` only takes effect after it has been applied to state,
so running `terraform destroy` immediately after setting it still drops without
purge. A sentence saying so would save S3 Tables users a confusing failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]