rambleraptor commented on code in PR #4426:
URL: https://github.com/apache/iceberg-python/pull/4426#discussion_r4620887905


##########
AGENTS.md:
##########
@@ -52,6 +52,13 @@ lives under `pyiceberg/`, organized by concern rather than 
by engine:
 - Use domain-specific exceptions from pyiceberg/exceptions.py for 
Iceberg-specific error conditions. For invalid arguments/values, ValueError is 
acceptable. Don't raise bare Exception.
 - Comments should be succinct and follow the same style of comments found in 
the rest of the codebase.
 
+### Spec Compliance
+
+<!-- markdown-link-check-disable-next-line -->
+- The [Iceberg 
spec](https://github.com/apache/iceberg/blob/main/format/spec.md) is the source 
of truth. Check changes to metadata, manifests, schemas, partitioning, 
transforms, or the commit path against it, and cite the relevant section when 
behavior is non-obvious.

Review Comment:
   We could potentially make that list larger (include work involving the 
catalogs?) and maybe even just tell the agents to always look at the Java 
reference implementation for any changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to