zeroshade commented on PR #144:
URL: 
https://github.com/apache/terraform-provider-iceberg/pull/144#issuecomment-6991964222

   #135 has landed on main (fb6181b), so this needs a rebase. When resolving 
`calculateSchemaUpdates`, the order should be:
   
   1. `validateSchemaEvolution` (reverts are evolutions from the current schema 
too, per the thread above)
   2. the existing-schema lookup (`set-current-schema` to a matching ID)
   3. `validateNewFieldIDs`, only for genuinely new schemas, so an exact revert 
that re-declares a dropped column with its old id is not rejected
   
   A unit test covering an exact revert past a dropped field would be a good 
addition alongside the promote-then-revert one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to