mbutrovich commented on code in PR #3724:
URL: https://github.com/apache/iceberg-rust/pull/3724#discussion_r4621315649


##########
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##########
@@ -103,7 +103,7 @@ impl<'a> ManifestFilterVisitor<'a> {
 
 const ROWS_MIGHT_MATCH: Result<bool> = Ok(true);
 const ROWS_CANNOT_MATCH: Result<bool> = Ok(false);
-const IN_PREDICATE_LIMIT: usize = 200;
+pub(crate) const IN_PREDICATE_LIMIT: usize = 200;

Review Comment:
   This is `pub(crate)` so `ManifestFilter` uses the same limit. Above it, 
`ManifestEvaluator` keeps a manifest that has a lower bound even if every 
literal falls outside the bounds, so a filter with a different limit would 
return different results. `test_manifest_list_mask_matches_manifest_evaluator` 
includes a 201-literal `IN` for this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to