iceberg-kitten opened a new pull request, #2643:
URL: https://github.com/apache/iceberg-go/pull/2643

   Depends on #2641 and #2642. The diff against `main` includes both earlier 
patches. [History-log-only 
diff](https://github.com/iceberg-kitten/iceberg-go/pull/2/files).
   
   Extend the eager v2 decoder to the snapshot and metadata logs. Ordinary 
entries contain two fields and can be decoded directly. Unusual entries use the 
general decoder, and each metadata filename owns its string.
   
   The parity tests exercise uncommon log entries, escaped filenames, duplicate 
log fields, and the document nesting limit.
   
   ## Benchmark
   
   | 64-snapshot workload | With #2642 | With this patch |
   | --- | ---: | ---: |
   | Warm metadata file load | 4.624 ms | 1.989 ms |
   | In-memory parse, bytes/op | 124,539 | 103,010 |
   | In-memory parse, allocs/op | 1,319 | 859 |
   
   File-load timings are medians from three matched rounds on one pinned core 
at approximately 0.9 GHz, with Go 1.26.10 and `GOGC=100`. Each load reads the 
same warm 66,321-byte v2 file and checks the schema width and snapshot 
sequence. The allocation rows are medians from three runs of the separate 
in-memory Go benchmark.
   
   ```sh
   GOMAXPROCS=1 GOGC=100 go test ./table -run '^$' \
     -bench 
'^BenchmarkParseMetadataBytes$/^schemas=1$/^specs=1$/^snapshots=64$' \
     -benchmem -benchtime=300ms -count=3
   ```
   
   Run the same command on the head of #2642 and on this branch.
   
   ### Full-stack comparison
   
   A separate run on the same 64-snapshot file at approximately 2.9 GHz 
produced these medians. There was one clock-matched round with four timing 
windows per implementation.
   
   | Implementation | Median load |
   | --- | ---: |
   | Java 1.12.0 | 0.185 ms |
   | Go with all three patches | 0.339 ms |
   | Rust upstream main (`641f59049e0a`) | 0.420 ms |
   | Go upstream main (`e7a4d96b505d`) | 3.287 ms |
   
   `make test` and `make lint` passed on the full stack.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to