dramaticlly commented on code in PR #18935:
URL: https://github.com/apache/iceberg/pull/18935#discussion_r4622113566
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -1158,6 +1158,12 @@ private Map<Integer, NestedField> lazyFieldsById() {
public static final class FileType extends NestedType {
public static final String NAME = "file";
public static final int NUM_NESTED_FIELDS = 6;
+ private static final int URI_ID_OFFSET = 1;
Review Comment:
nit: with current logic probably dont even need changes in this class
##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -83,6 +83,16 @@ public class TestSchemaUpdate {
private static final int SCHEMA_LAST_COLUMN_ID = 23;
+ private static final Schema FILE_SCHEMA =
+ new Schema(
+ required(1, "id", Types.LongType.get()),
+ optional(2, "photo", Types.FileType.of(2)),
Review Comment:
nit: would be great to have at least 1 test which have file type is
non-top-level field, try with delete column or rename or any mutation applied
to observe the expected result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]