jiwen624 commented on code in PR #18882:
URL: https://github.com/apache/iceberg/pull/18882#discussion_r4622906361
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -840,7 +840,7 @@ public static PlanTableScanResponse planTableScan(
IncrementalAppendScan incrementalScan =
table
.newIncrementalAppendScan()
- .fromSnapshotInclusive(request.startSnapshotId())
+ .fromSnapshotExclusive(request.startSnapshotId())
Review Comment:
Non-blocking: should equal start/end snapshot IDs return 400 or an empty
plan? Worth clarifying in the REST spec as a follow-up.
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTScanPlanning.java:
##########
@@ -433,6 +433,30 @@ void incrementalScan(
.contains(FILE_C.location(), FILE_B.location());
}
+ @Test
+ void incrementalScanExcludesStartSnapshot() {
Review Comment:
Nit: The existing `incrementalScan` test above doesn't reach this path. It
seems the `RESTTable` doesn't override `newIncrementalAppendScan()`, so it
plans locally and the sync/async modes do nothing. Not sure if it's worth a
follow-up though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]