linzch3 commented on PR #4419: URL: https://github.com/apache/iceberg-python/pull/4419#issuecomment-6998540924
Hi, thx both for the careful review! Agreed on the write path, I kept the old reject behavior for appends and only prune when reading data files. Also prune before type conversion now so unsupported types in ID-less columns don't break reads, and added tests for the list element / map key ID guards. For the map nit, a map with an ID only on its key now gets dropped as a whole on read, and is still rejected on write. Pushed an update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
