WZhuo opened a new pull request, #1144: URL: https://github.com/apache/iceberg-cpp/pull/1144
Phase 1 of #909: pin [apache/iceberg-verification](https://github.com/apache/iceberg-verification) as a git submodule at `testing/iceberg-verification`, and add `verification_test`, which runs the `types` and `schema` surfaces of its table-spec fixtures. Each fixture case becomes one GTest parameterized test named after `<subdir>/<case-id>`. The types cases go through `TypeFromJson` and the schema cases through `SchemaFromJson`. Each result is then projected into the fixture's `decoded` shape through public accessors and compared field by field. Every difference is reported with its path, for example `fields[2].parent`. The subscribed subdirectories are `types/{primitive,nested,variant,geospatial}` and `schema/{core,unknown}`. The test is behind a new `ICEBERG_BUILD_VERIFICATION_TESTS` option, off by default. To run it: ```bash git submodule update --init testing/iceberg-verification cmake -S . -B build -DICEBERG_BUILD_VERIFICATION_TESTS=ON cmake --build build --target verification_test ./build/src/iceberg/test/verification_test ``` `ICEBERG_VERIFICATION_DIR` points the test at another checkout of the fixtures. Two things differ from the plan in #909: - If the option is on and the fixtures are missing, CMake fails at configure time. The plan had the tests skip instead, which would let a misconfigured run pass while testing nothing. With the option off by default, source tarballs are not affected. - There is no known-failures list. Every case that diverges from its fixture fails. Advisory cases (`normative_level: should`) are reported as skips. The test is not added to CI until all cases pass. Currently 77 cases pass and 4 fail: | Case | Issue | |---|---| | `schema/unknown/reject-unknown-required` | #1141 | | `types/primitive/decimal-9-2`, `types/primitive/decimal-9-2-spaced` | #1142 | | `types/primitive/decimal-precision-over-38` | #1143 | Validation: built and ran `verification_test` locally on macOS with the results above. Configuring with a nonexistent `ICEBERG_VERIFICATION_DIR` fails as expected. pre-commit passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
