WZhuo opened a new pull request, #1146:
URL: https://github.com/apache/iceberg-cpp/pull/1146

   Closes #1142.
   
   Since apache/iceberg#18145, Appendix C of the spec serializes a decimal type 
as `"decimal(<P>, <S>)"`, with `"decimal(9, 2)"` as its only example. `ToJson` 
wrote `"decimal(9,2)"`. `DecimalType::ToString` and Java already write the 
spaced form.
   
   `TypeFromJson` accepts both spellings, so metadata written before this 
change still reads.
   
   Tests:
   - The decimal case in `TypeJsonTest.SingleTypeRoundTrip` now expects 
`"decimal(10, 2)"`.
   - `TypeJsonTest.DecimalWithoutSpaceWritesCanonicalForm` checks that 
`"decimal(10,2)"` still parses and is written back as `"decimal(10, 2)"`.
   
   The iceberg-verification cases `types/primitive/decimal-9-2` and 
`types/primitive/decimal-9-2-spaced` (#1144) pass with this change. 
`rest_catalog_test` has 3 auth failures locally that also occur on unmodified 
main. All other tests and pre-commit pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to