binarybrain-009 commented on PR #18691: URL: https://github.com/apache/iceberg/pull/18691#issuecomment-7002459212
@pvary Addressed in 65bfafcb1. Renamed the shared test to dropTableThatAlreadyExistsAsView and added a loadView check against the original UUID. Added dropViewThatAlreadyExistsAsTable with the same preservation check for tables. That exposed Hive throwing NoSuchViewException for this case, so dropView now returns false. The shared cases pass for Hive, JDBC, in-memory and both REST configurations, and the Hive and Nessie view suites and formatting/checkstyle checks pass. Both Nessie mismatch tests are temporarily disabled pending #18912, which now fixes both directions. Could you take another look? These latest follow-ups were generated with Codex and are marked as awaiting my personal review in the disclosure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
