AynSiddiqui commented on PR #2639: URL: https://github.com/apache/iceberg-go/pull/2639#issuecomment-7002651654
1. The cache assertion now loads `writer.key`. With removal disabled, it fails. 2. Added `truncate[2](cat)` -> `truncate[4](cat)` with `cat="ab"` rows on both specs. It checks each delete file against its data file, and it is the only case that fails when the spec ID is dropped from the writer key. 3. Added the comment on the unpartitioned-writer guard. 4. Added a note at the end of "Unreleased compatibility notes" in `website/src/releases.md`. On tables with old delete files, scans and re-running `Delete` can fail with the spec-mismatch error, and some deletes are silently missed instead; re-running those applies them. For the mismatch error, I checked that removing the offending delete files with `Transaction.NewRewrite`, then re-running the deletes, keeps valid deletes. I did not test Java Iceberg. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
